Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTC-1037: adjusting productPicker and PolicyOfficerPicker labels/plac… #42

Merged
merged 1 commit into from Apr 11, 2023
Merged

OTC-1037: adjusting productPicker and PolicyOfficerPicker labels/plac… #42

merged 1 commit into from Apr 11, 2023

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Apr 5, 2023 •
edited

…eholders

CORE PR AND PRODUCT PR REQUIRED

OTC-1037

Changes:

  • I added the renderInput prop to the PolicyOfficerPicker to fix the issue with crashing label and placeholder.
  • I adjusted props (provided to the ProductPicker and PolicyOfficerPicker) to implemented logic.

This was referenced Apr 5, 2023
Merged
Merged
@olewandowski1 olewandowski1 marked this pull request as ready for review April 5, 2023 13:21
@delcroip delcroip merged commit 679c9a8 into develop Apr 11, 2023
1 check passed
@delcroip delcroip deleted the feature/OTC-1037 branch April 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delcroip delcroip delcroip approved these changes

@dragos-dobre dragos-dobre Awaiting requested review from dragos-dobre

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

@sniedzielski sniedzielski Awaiting requested review from sniedzielski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olewandowski1 @delcroip