Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTC-151 : Missing statistics for uploading of health facilities into the register #116

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

hirensoni913
Copy link
Collaborator

@@ -343,11 +343,11 @@ Partial Public Class UploadICD
"<b>" & imisgen.getMessage("L_HF") & "</b><br>" &
imisgen.getMessage("L_SENT") & ": " & Output("SentHF") & "<br>" &
imisgen.getMessage("L_INSERTED") & ": " & Output("Inserts") & "<br>" &
imisgen.getMessage("L_UPDATED") & ": " & Output("Updates") & "</br><br>" &
"<b>" & imisgen.getMessage("L_HFCATCHMENT") & "</b><br>" &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this other messages for HF ? there is still HF upload
Uploading image.png…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the other part because those parameters from output parameters were removed in DAL by a previous programmer. And if I am not wrong they are also removed from SP but in the user interface they forgot to remove. And that's why it was throwing an exception and the statistics were not displaying.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the SP, the parameters are still there. Now the question is why they were commented in DAL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it is in IMIS/Registers.aspx.vb

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is in IMIS/Register.aspx.vb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it doesn't solve the issue, because there is no error but not statistic either

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you have the latest Develop branch? Because in the latest branch it was not working.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the chf dev and even there you will find the same issue.

@dragos-dobre dragos-dobre merged commit 385f833 into develop Sep 10, 2021
@dragos-dobre dragos-dobre deleted the feature/OTC-151 branch September 10, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants