OTC-10: Capitation Payment Report use data from tblCapitationPayment #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragos-dobre
requested changes
Mar 30, 2021
|
I will wait for the call of the batch to modular before merging to develop. |
|
@dragos-dobre I've added calling modular batch process, can you review? |
dragos-dobre
requested changes
Apr 9, 2021
IMIS/ProcessBatches.aspx.vb
Outdated
| If dt Is Nothing Then Exit Sub | ||
| Session("Report") = dt | ||
|
|
||
| Response.Redirect("Report.aspx?r=ca&tid=18") |
There was a problem hiding this comment.
tid is used for getting back to reports.aspx. As the capitation report is not in the report list, I don't think we need to add it here. Please remove.
There was a problem hiding this comment.
tid removed from redireciton.
IMIS/Reports.aspx.vb
Outdated
| If Not getCapitationPayment() Then Exit Sub | ||
| Session("Report") = dt | ||
| url = "Report.aspx?r=ca&tid=18" | ||
| ElseIf SelectedValueID = 19 Then | ||
| If Not getRejectedPhoto() Then Exit Sub | ||
| Session("Report") = dt | ||
| url = "Report.aspx?r=rp&tid=19" |
There was a problem hiding this comment.
As you removed the cap rep, shouldn't you change the tid to 18 to match SelectedValueID? I don't understand why Exact didn't concat url with SelectedValueID.
There was a problem hiding this comment.
You're right, I changed tids for every report in which SelectedValueID has changed.
dragos-dobre
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OTC-10
Procedure uspSSRSCapitationPayment is replaced with uspSSRSRetrieveCapitationPaymentReportData. Before report is generated, it is checked whether the batch run has been executed for given period and location.