Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add openim helm charts test cicd #31

Merged
merged 22 commits into from
Dec 4, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 30, 2023


馃攳 What type of PR is this?

/kind feature

馃憖 What this PR does / why we need it:

This PR implements the CI/CD pipeline design for OpenIMSDK Helm charts as proposed in RFC #0000. This includes automated testing, security scanning, versioning, and publishing of Helm charts, ensuring their reliability and stability.

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #30

馃摑 Special notes for your reviewer:

This implementation significantly automates our deployment process, reducing manual errors and improving efficiency. Please review the details in the CI/CD pipeline sections.

馃幆 Describe how to verify it

To verify, please execute make all locally, ensuring all tests pass and the Helm charts are properly versioned and published.

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

For detailed information, please refer to the RFC document: OpenIMSDK CI/CD Pipeline Design

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@cubxxw cubxxw added documentation enhancement New feature or request help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question Further information is requested labels Nov 30, 2023
Copy link
Contributor

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw force-pushed the feat/add-helm-chartstest-cicd branch from ac1f35c to d39ca75 Compare November 30, 2023 12:15
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw merged commit ea83c93 into openimsdk:main Dec 4, 2023
5 of 7 checks passed
@cubxxw cubxxw deleted the feat/add-helm-chartstest-cicd branch December 4, 2023 04:15
@openimsdk openimsdk locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question Further information is requested size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃敭[RFC #0009]: CI/CD Design for OpenIMSDK Helm Charts
1 participant