Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not support redis cluster. CROSSSLOT Keys in request don't hash to the same slot #1258

Merged
merged 29 commits into from
Oct 23, 2023
Merged

fix: not support redis cluster. CROSSSLOT Keys in request don't hash to the same slot #1258

merged 29 commits into from
Oct 23, 2023

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Oct 20, 2023 •
edited by FGadvancer
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1077,resolves #1090

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

withchao and others added 27 commits October 10, 2023 18:01
@withchao
feat: v2 to v3 data conversion
cb9e5dc
@withchao
feat: v2 to v3 data conversion
5171494
@withchao
Merge branch 'openimsdk:main' into main
fbcdbaa
@withchao
fix: CallbackBeforeCreateGroup
950e6b7
@withchao
Merge branch 'openimsdk:main' into main
9eeb5df
@withchao
fix: NotificationUserInfoUpdate
dfbdb2b
@withchao
fix: NotificationUserInfoUpdate
af03bc6
@withchao
chore: update pkg github.com/OpenIMSDK/protocol v0.0.26
dbe3936
@withchao
chore: code format
b5d2ae3
@withchao
Merge remote-tracking branch 'upstream/main'
a2718e2 
# Conflicts:
#	go.mod
#	go.sum
@withchao
update pkg
c107c63
@withchao
Merge branch 'openimsdk:main' into main
62b43fd
@withchao
Merge branch 'openimsdk:main' into main
59a505b
@withchao
feat: QuitGroup support administrator operations
6e55143
@withchao
feat: QuitGroup support administrator operations
e08f2db
@withchao
fix: checkMongo uri
9f3f083
@withchao
fix: k8s minio prefix
4159b34
@withchao
Merge branch 'openimsdk:main' into main
dc02c3e
@withchao
fix: k8s minio prefix
883e55e
@withchao
fix: k8s minio prefix
836eb42
@withchao
fix: k8s minio prefix test
cca8b75
@withchao
fix: k8s minio prefix test
a086ad6
@withchao
Merge remote-tracking branch 'upstream/main'
8431faa 
# Conflicts:
#	go.mod
#	go.sum
#	tools/component/component.go
@withchao
fix: GetUsersInfo cache
89a98fc
@withchao
fix: redis cache
3f52d83
@withchao
fix: redis remove pipeline
a64b046
@withchao
Merge branch 'openimsdk:main' into main
8dd9208
@withchao withchao requested a review from cubxxw as a code owner October 20, 2023 09:38
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 20, 2023
@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 20, 2023 09:38 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

skiffer-git
skiffer-git previously approved these changes Oct 23, 2023
View reviewed changes
@withchao
Merge remote-tracking branch 'upstream/main'
fd37526 
# Conflicts:
#	pkg/common/db/cache/conversation.go
#	pkg/common/db/cache/group.go
#	pkg/common/db/cache/meta_cache.go
#	pkg/common/db/cache/msg.go
#	pkg/common/db/cache/user.go
@withchao
fix: redis remove pipeline
ec3e018
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 23, 2023 12:23 — with GitHub Actions Inactive
@withchao withchao added this pull request to the merge queue Oct 23, 2023
Merged via the queue into openimsdk:main with commit 6ffcfbe Oct 23, 2023
15 of 16 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Oct 23, 2023
@github-actions github-actions bot added this to the v3.1 milestone Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@openimbot openimbot openimbot approved these changes

@skiffer-git skiffer-git skiffer-git left review comments

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
4 participants
@withchao @skiffer-git @cubxxw @openimbot