-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create database name #1285
Conversation
CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA. |
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
=======================================
+ Coverage 0 2.44% +2.44%
=======================================
Files 0 13 +13
Lines 0 778 +778
=======================================
+ Hits 0 19 +19
- Misses 0 756 +756
- Partials 0 3 +3
|
I have read the CLA Document and I hereby sign the CLA |
Thank you for your contribution to the OpenIM community. This is your first PR and we truly appreciate your help. |
🔍 What type of PR is this?
/kind bug
👀 What this PR does / why we need it:
It will failed when you init app with a custom database name which contains '-' (eg: "im-db").
Screenshot:
🅰 Which issue(s) this PR fixes:
Fixes #
📝 Special notes for your reviewer:
option
.defer sqlDB.Close()
has been moved.🎯 Describe how to verify it
go test -run ^TestMaybeCreateTable$ github.com/openimsdk/open-im-server/v3/pkg/common/db/relation
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: