Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details optimization #1293

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Details optimization #1293

merged 3 commits into from
Nov 5, 2023

Conversation

zm50
Copy link
Contributor

@zm50 zm50 commented Oct 30, 2023


🔍 What type of PR is this?

/kind cleanup

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

This PR improves some of the details of the code.

🅰 Which issue(s) this PR fixes:

clean up the code

Fixes #

📝 Special notes for your reviewer:

I suggest reading the corresponding code for better understanding.

🎯 Describe how to verify it

There are several methods to verify the health of this PR:

Local verification by fetching my PR through gh or git.
Verification through CICD.
Local verification by running make start.

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@zm50 zm50 requested a review from cubxxw as a code owner October 30, 2023 00:41
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2023
@kubbot
Copy link
Member

kubbot commented Oct 30, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 00:41 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1293 (a3cf3d1) into main (726f14f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1293   +/-   ##
=====================================
  Coverage   2.44%   2.44%           
=====================================
  Files         13      13           
  Lines        778     778           
=====================================
  Hits          19      19           
  Misses       756     756           
  Partials       3       3           

@zm50 zm50 requested review from skiffer-git, FGadvancer and a team as code owners October 30, 2023 01:06
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2023
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:06 — with GitHub Actions Inactive
@cubxxw
Copy link
Contributor

cubxxw commented Oct 30, 2023

I hope this message finds you well. I wanted to bring to your attention that the golang lint CI did not pass on your recent PR. Upon further review, it appears that your code does not meet our code standards, specifically the lack of a space before the return statement.

Would it be possible for you to make the necessary adjustments to your code? This would greatly help us maintain our code quality and ensure a smooth integration process.

Thank you for your understanding and cooperation.

image

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:33 — with GitHub Actions Inactive
@zm50
Copy link
Contributor Author

zm50 commented Oct 30, 2023

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@zm50
Copy link
Contributor Author

zm50 commented Oct 30, 2023

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Oct 30, 2023
@kubbot kubbot enabled auto-merge November 5, 2023 10:35
@kubbot kubbot added this pull request to the merge queue Nov 5, 2023
Merged via the queue into openimsdk:main with commit a9e5901 Nov 5, 2023
16 of 17 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 5, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 5, 2023
@zm50 zm50 deleted the zuimo branch November 6, 2023 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants