-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details optimization #1293
Details optimization #1293
Conversation
CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA. |
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
=====================================
Coverage 2.44% 2.44%
=====================================
Files 13 13
Lines 778 778
=====================================
Hits 19 19
Misses 756 756
Partials 3 3 |
I hope this message finds you well. I wanted to bring to your attention that the golang lint CI did not pass on your recent PR. Upon further review, it appears that your code does not meet our code standards, specifically the lack of a space before the return statement. Would it be possible for you to make the necessary adjustments to your code? This would greatly help us maintain our code quality and ensure a smooth integration process. Thank you for your understanding and cooperation. |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
🔍 What type of PR is this?
/kind cleanup
👀 What this PR does / why we need it:
This PR improves some of the details of the code.
🅰 Which issue(s) this PR fixes:
clean up the code
Fixes #
📝 Special notes for your reviewer:
I suggest reading the corresponding code for better understanding.
🎯 Describe how to verify it
There are several methods to verify the health of this PR:
Local verification by fetching my PR through gh or git.
Verification through CICD.
Local verification by running make start.
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: