Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce lock msg transfer #1308

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

rfyiamcool
Copy link
Contributor

@rfyiamcool rfyiamcool commented Oct 31, 2023

summary

  1. reduce lock for sarama.Value.
  2. refactor some code.
  3. record push queue duration.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2023
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:54 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1308 (1fd5cd3) into main (2496a16) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1308   +/-   ##
=====================================
  Coverage   4.30%   4.30%           
=====================================
  Files         45      45           
  Lines       3809    3809           
=====================================
  Hits         164     164           
  Misses      3634    3634           
  Partials      11      11           

@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 08:57 — with GitHub Actions Inactive
cubxxw
cubxxw previously approved these changes Nov 2, 2023
kubbot
kubbot previously approved these changes Nov 5, 2023
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@cubxxw cubxxw added this pull request to the merge queue Nov 13, 2023
Merged via the queue into openimsdk:main with commit fd42c6d Nov 13, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 13, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants