Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong column #1309

Merged
merged 2 commits into from
Nov 5, 2023
Merged

fix: wrong column #1309

merged 2 commits into from
Nov 5, 2023

Conversation

a3d21
Copy link
Contributor

@a3d21 a3d21 commented Oct 31, 2023

修复列名错误,导致无法正确过滤通知

@a3d21 a3d21 requested a review from cubxxw as a code owner October 31, 2023 09:35
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2023
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@kubbot
Copy link
Member

kubbot commented Oct 31, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:35 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1309 (5b35f79) into main (a4b28c9) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1309   +/-   ##
=====================================
  Coverage   2.44%   2.44%           
=====================================
  Files         13      13           
  Lines        778     778           
=====================================
  Hits          19      19           
  Misses       756     756           
  Partials       3       3           
Files Coverage Δ
pkg/common/db/relation/conversation_model.go 0.00% <0.00%> (ø)

@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 31, 2023 09:48 — with GitHub Actions Inactive
@cubxxw
Copy link
Contributor

cubxxw commented Oct 31, 2023

@a3d21 第一次贡献你需要评论下面这句话:

I have read the CLA Document and I hereby sign the CLA

@kubbot kubbot enabled auto-merge November 5, 2023 10:35
@kubbot kubbot added this pull request to the merge queue Nov 5, 2023
Merged via the queue into openimsdk:main with commit 450fe26 Nov 5, 2023
17 of 18 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Nov 5, 2023
@github-actions github-actions bot added this to the v3.1 milestone Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants