Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce register client latency #1312

Merged
merged 1 commit into from
Nov 2, 2023
Merged

perf: reduce register client latency #1312

merged 1 commit into from
Nov 2, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

  1. reduce register client latency.
  2. go1.19 support atomic type.

@rfyiamcool
perf: reduce register client latency
51d3b67 
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2023
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 16:20 — with GitHub Actions Inactive
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1312 (51d3b67) into main (a4b28c9) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1312   +/-   ##
=====================================
  Coverage   2.44%   2.44%           
=====================================
  Files         13      13           
  Lines        778     778           
=====================================
  Hits          19      19           
  Misses       756     756           
  Partials       3       3

cubxxw
cubxxw approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cubxxw cubxxw added this pull request to the merge queue Nov 2, 2023
Merged via the queue into openimsdk:main with commit 1664579 Nov 2, 2023
19 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 2, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FGadvancer FGadvancer FGadvancer approved these changes

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg was automatically assigned from openimsdk/openim

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rfyiamcool @FGadvancer @cubxxw