-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve gzip performance with sync.pool #1321
Merged
cubxxw
merged 2 commits into
openimsdk:main
from
rfyiamcool:perf/improve_gzip_performance
Nov 10, 2023
Merged
perf: improve gzip performance with sync.pool #1321
cubxxw
merged 2 commits into
openimsdk:main
from
rfyiamcool:perf/improve_gzip_performance
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
rfyiamcool
requested review from
skiffer-git,
FGadvancer and
a team
as code owners
November 2, 2023 03:16
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 2, 2023
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1321 +/- ##
========================================
- Coverage 2.41% 2.04% -0.38%
========================================
Files 13 26 +13
Lines 786 1908 +1122
========================================
+ Hits 19 39 +20
- Misses 764 1861 +1097
- Partials 3 8 +5
|
FGadvancer
previously approved these changes
Nov 10, 2023
cubxxw
approved these changes
Nov 10, 2023
openimbot
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
use sync.pool to improve gzip compress/decompress performance. refer to the optimization in the opentelemetry collector.
https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/confighttp/compressor.go#L27
benchmark result