Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get user in group members nil panic #1324

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

a3d21
Copy link
Contributor

@a3d21 a3d21 commented Nov 2, 2023

修复GetUserInGroupMembers nil panic

@a3d21 a3d21 requested review from skiffer-git, FGadvancer and a team as code owners November 2, 2023 06:17
@a3d21 a3d21 requested a review from Bloomingg November 2, 2023 06:17
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2023
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
@kubbot
Copy link
Member

kubbot commented Nov 2, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@a3d21 a3d21 temporarily deployed to openim November 2, 2023 06:17 — with GitHub Actions Inactive
Copy link
Contributor

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1324 (97fc0e3) into main (d2f0af1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1324   +/-   ##
=====================================
  Coverage   2.44%   2.44%           
=====================================
  Files         13      13           
  Lines        778     778           
=====================================
  Hits          19      19           
  Misses       756     756           
  Partials       3       3           

@openimbot openimbot added this pull request to the merge queue Nov 6, 2023
Merged via the queue into openimsdk:main with commit 1aef30d Nov 6, 2023
18 of 19 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 6, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants