Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: notify nodes concurrently on register #1327

Merged

Conversation

rfyiamcool
Copy link
Contributor

summary

notify client info to nodes concurrently on register.

  1. remove unused hubServer object.
  2. format some code
  3. format import package
  4. err lint.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2023
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim November 2, 2023 09:11 — with GitHub Actions Inactive
Copy link
Contributor

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1327 (a630f42) into main (2496a16) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1327      +/-   ##
========================================
- Coverage   4.30%   4.29%   -0.02%     
========================================
  Files         45      45              
  Lines       3809    3819      +10     
========================================
  Hits         164     164              
- Misses      3634    3644      +10     
  Partials      11      11              
Files Coverage Δ
internal/msggateway/n_ws_server.go 0.00% <0.00%> (ø)

cubxxw
cubxxw previously approved these changes Nov 3, 2023
@kubbot kubbot enabled auto-merge November 5, 2023 10:38
@cubxxw
Copy link
Contributor

cubxxw commented Nov 10, 2023

@rfyiamcool I kindly request your assistance in resolving a conflict.

auto-merge was automatically disabled November 13, 2023 03:34

Head branch was pushed to by a user without write access

@rfyiamcool rfyiamcool force-pushed the perf/concurrent_notify_node_on_register branch from 8c05cb4 to 5b831d3 Compare November 13, 2023 03:34
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@rfyiamcool rfyiamcool force-pushed the perf/concurrent_notify_node_on_register branch from 5b831d3 to a630f42 Compare November 13, 2023 05:00
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2023
@openimbot openimbot added this pull request to the merge queue Nov 13, 2023
Merged via the queue into openimsdk:main with commit 69eb24f Nov 13, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 13, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants