Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: S3 server cache #1329

Merged
merged 16 commits into from
Nov 3, 2023
Merged

feat: S3 server cache #1329

merged 16 commits into from
Nov 3, 2023

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Nov 2, 2023


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #1328

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 2, 2023
@withchao withchao temporarily deployed to openim November 2, 2023 09:25 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
Copy link
Contributor

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 09:27 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1329 (7c8479d) into main (62e9980) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1329   +/-   ##
=====================================
  Coverage   2.41%   2.41%           
=====================================
  Files         13      13           
  Lines        786     786           
=====================================
  Hits          19      19           
  Misses       764     764           
  Partials       3       3           

@cubxxw cubxxw enabled auto-merge November 2, 2023 09:57
@cubxxw cubxxw added this pull request to the merge queue Nov 3, 2023
Merged via the queue into openimsdk:main with commit cb0bf64 Nov 3, 2023
17 of 18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 3, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: S3 server cache
3 participants