-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add concurrency and pipeline for redis cache #1338
Merged
cubxxw
merged 3 commits into
openimsdk:main
from
rfyiamcool:perf/add_concurrency_pipeline_for_cache
Nov 13, 2023
Merged
perf: add concurrency and pipeline for redis cache #1338
cubxxw
merged 3 commits into
openimsdk:main
from
rfyiamcool:perf/add_concurrency_pipeline_for_cache
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1338 +/- ##
========================================
+ Coverage 2.41% 4.10% +1.68%
========================================
Files 13 22 +9
Lines 786 2120 +1334
========================================
+ Hits 19 87 +68
- Misses 764 2028 +1264
- Partials 3 5 +2
|
cubxxw
approved these changes
Nov 10, 2023
openimbot
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
enablePipeline
配置,用户可以选配来开启 redis pipeline 模式.go-redis
库包是支持在集群模式下,pipeline 下不同key 的拆离并发操作,但这毕竟是 sdk 层实现,对于容错的处理有限,多数场景是够用了。暂时先写 set/get 这两个方法,后面有空继续优化。😁