Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add test scripts #1341

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Feat/add test scripts #1341

merged 3 commits into from
Nov 5, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 5, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1340

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Copy link
Contributor

sweep-ai bot commented Nov 5, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1341 (d762f96) into main (a4b28c9) will decrease coverage by 0.03%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #1341      +/-   ##
========================================
- Coverage   2.44%   2.41%   -0.03%     
========================================
  Files         13      13              
  Lines        778     786       +8     
========================================
  Hits          19      19              
- Misses       756     764       +8     
  Partials       3       3              

see 2 files with indirect coverage changes

@kubbot kubbot added this pull request to the merge queue Nov 5, 2023
Merged via the queue into openimsdk:main with commit a0621ae Nov 5, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 5, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants