Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☀️ feat: Enhancing OpenIM with Integrated E2E Testing and CI/CD Enhancements #1359

Merged
merged 20 commits into from
Nov 10, 2023
Merged

☀️ feat: Enhancing OpenIM with Integrated E2E Testing and CI/CD Enhancements #1359

merged 20 commits into from
Nov 10, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 7, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1119
Resolves #1355, resolves #1357

📝 Special notes for your reviewer:

We encourage contributions from community members who have experience with E2E testing and CI/CD practices. Suggestions for testing tools, test cases, and CI integration strategies are most welcome.

OpenIM Linux System E2E Test

🎯 Describe how to verify it

  1. CICD
  2. local(codespaces ci)
make test-api
make test-e2e

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

This issue outlines the need for comprehensive E2E testing within the OpenIMSDK/Open-IM-Server repository. The implementation plan provided aims to guide the setup, development, and integration of E2E tests into the CI pipeline, ensuring rigorous testing standards and maintaining system reliability as the project evolves.

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@kubbot
Copy link
Member

kubbot commented Nov 7, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

Copy link
Contributor

sweep-ai bot commented Nov 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1359 (4a38dc6) into main (a32e94b) will increase coverage by 3.19%.
Report is 1 commits behind head on main.
The diff coverage is 79.48%.

@@           Coverage Diff            @@
##            main   #1359      +/-   ##
========================================
+ Coverage   2.41%   5.61%   +3.19%     
========================================
  Files         13      23      +10     
  Lines        786    1353     +567     
========================================
+ Hits          19      76      +57     
- Misses       764    1273     +509     
- Partials       3       4       +1     
Files Coverage Δ
pkg/common/db/relation/conversation_model.go 0.00% <ø> (ø)
pkg/common/discoveryregister/discoveryregister.go 0.00% <ø> (ø)
test/e2e/e2e.go 100.00% <100.00%> (ø)
test/e2e/framework/config/config.go 100.00% <100.00%> (ø)
pkg/common/startrpc/start.go 21.05% <33.33%> (ø)
pkg/common/config/parse.go 0.00% <0.00%> (ø)
pkg/common/prommetrics/prommetrics.go 42.85% <0.00%> (ø)

... and 4 files with indirect coverage changes

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw added this pull request to the merge queue Nov 10, 2023
Merged via the queue into openimsdk:main with commit e2004c1 Nov 10, 2023
19 of 21 checks passed
@cubxxw cubxxw deleted the feat/super-openim-test-e2e-api branch November 10, 2023 11:37
@github-actions github-actions bot added this to the v3.1 milestone Nov 10, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
4 participants