Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting adjustments, script removal, and helm template rendering #1389

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Formatting adjustments, script removal, and helm template rendering #1389

merged 8 commits into from
Nov 13, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 13, 2023

🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

This PR makes some formatting adjustments and removes some unnecessary scripts. It also adds the ability to use helm template to render all helm templates into a single file for easy download.

🅰 Which issue(s) this PR fixes:

Fixes #1390

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1389 (0c35d00) into main (2ac54e0) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1389      +/-   ##
========================================
- Coverage   4.37%   4.35%   -0.03%     
========================================
  Files         49      49              
  Lines       4090    4113      +23     
========================================
  Hits         179     179              
- Misses      3899    3922      +23     
  Partials      12      12              
Files Coverage Δ
test/e2e/framework/config/config.go 25.80% <0.00%> (-74.20%) ⬇️

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw added this pull request to the merge queue Nov 13, 2023
Merged via the queue into openimsdk:main with commit 0d5fe4e Nov 13, 2023
20 checks passed
@cubxxw cubxxw deleted the feat/openim-ctl branch November 13, 2023 13:27
@github-actions github-actions bot added this to the v3.1 milestone Nov 13, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: Add support for helm template rendering in OpenIM
3 participants