-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting adjustments, script removal, and helm template rendering #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubxxw
requested review from
FGadvancer,
skiffer-git,
a team,
Bloomingg and
withchao
as code owners
November 13, 2023 11:54
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 13, 2023
Apply Sweep Rules to your PR?
|
pull-request-size
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 13, 2023
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
cubxxw
changed the title
Feat/openim ctl
Formatting adjustments, script removal, and helm template rendering
Nov 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #1389 +/- ##
========================================
- Coverage 4.37% 4.35% -0.03%
========================================
Files 49 49
Lines 4090 4113 +23
========================================
Hits 179 179
- Misses 3899 3922 +23
Partials 12 12
|
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
kubbot
approved these changes
Nov 13, 2023
openimbot
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
/kind documentation
/kind feature
👀 What this PR does / why we need it:
This PR makes some formatting adjustments and removes some unnecessary scripts. It also adds the ability to use helm template to render all helm templates into a single file for easy download.
🅰 Which issue(s) this PR fixes:
Fixes #1390
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: