Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deployment and design of management backend and monitoring #1432

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 18, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Copy link
Contributor

sweep-ai bot commented Nov 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b17c6ec) 4.54% compared to head (baa205f) 4.54%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1432   +/-   ##
=====================================
  Coverage   4.54%   4.54%           
=====================================
  Files         49      49           
  Lines       4140    4140           
=====================================
  Hits         188     188           
  Misses      3940    3940           
  Partials      12      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Nov 18, 2023
Merged via the queue into openimsdk:main with commit 75375ad Nov 18, 2023
19 of 21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 18, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants