Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update user's info will modify user create time when modify user… #1446

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fix: update user's info will modify user create time when modify user… #1446

merged 1 commit into from
Nov 26, 2023

Conversation

FGadvancer
Copy link
Collaborator

…'s nickname or avatar.


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1445

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2023
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@FGadvancer FGadvancer mentioned this pull request Nov 24, 2023
Closed
@cubxxw cubxxw added this pull request to the merge queue Nov 26, 2023
Merged via the queue into openimsdk:main with commit e404699 Nov 26, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfyiamcool rfyiamcool rfyiamcool approved these changes

@cubxxw cubxxw cubxxw approved these changes

@openimbot openimbot openimbot approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Bug: update user's info will reset user's registered time.
4 participants
@FGadvancer @rfyiamcool @cubxxw @openimbot