Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1477

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Update README.md #1477

merged 1 commit into from
Nov 26, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 26, 2023


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2023
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw added this pull request to the merge queue Nov 26, 2023
Merged via the queue into main with commit 1f7dfa3 Nov 26, 2023
19 of 20 checks passed
@cubxxw cubxxw deleted the cubxxw-patch-1 branch November 26, 2023 03:19
@github-actions github-actions bot added this to the v3.1 milestone Nov 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kubbot kubbot kubbot approved these changes

@openimbot openimbot openimbot approved these changes

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cubxxw @kubbot @openimbot