Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grace shutdown for gw #1478

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

add grace shutdonw for gateway server.

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Copy link
Contributor

sweep-ai bot commented Nov 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (f935d36) 4.97% compared to head (8d0d7ae) 4.90%.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 33 Missing ⚠️
pkg/common/startrpc/start.go 0.00% 30 Missing ⚠️
internal/msggateway/init.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1478      +/-   ##
========================================
- Coverage   4.97%   4.90%   -0.08%     
========================================
  Files         49      49              
  Lines       4162    4224      +62     
========================================
  Hits         207     207              
- Misses      3943    4005      +62     
  Partials      12      12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Nov 29, 2023
Merged via the queue into openimsdk:main with commit 35bac04 Nov 29, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 29, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants