Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add callback func #1480

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: add callback func #1480

merged 5 commits into from
Nov 28, 2023

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1421

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (f935d36) 4.97% compared to head (683e9f0) 4.96%.

Files Patch % Lines
internal/msggateway/callback.go 0.00% 15 Missing ⚠️
pkg/common/http/http_client.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1480      +/-   ##
========================================
- Coverage   4.97%   4.96%   -0.02%     
========================================
  Files         49      49              
  Lines       4162    4172      +10     
========================================
  Hits         207     207              
- Misses      3943    3953      +10     
  Partials      12      12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cubxxw
cubxxw previously approved these changes Nov 28, 2023
auto-merge was automatically disabled November 28, 2023 06:29

Head branch was pushed to by a user without write access

@cubxxw cubxxw added this pull request to the merge queue Nov 28, 2023
Merged via the queue into openimsdk:main with commit 02142c5 Nov 28, 2023
36 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 28, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add callback function
4 participants