-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add callback func #1480
Merged
Merged
feat: add callback func #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhaoling
requested review from
skiffer-git,
FGadvancer,
a team,
cubxxw,
Bloomingg and
withchao
as code owners
November 27, 2023 07:33
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Nov 27, 2023
Apply Sweep Rules to your PR?
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
========================================
- Coverage 4.97% 4.96% -0.02%
========================================
Files 49 49
Lines 4162 4172 +10
========================================
Hits 207 207
- Misses 3943 3953 +10
Partials 12 12 ☔ View full report in Codecov by Sentry. |
cubxxw
previously approved these changes
Nov 28, 2023
auto-merge was automatically disabled
November 28, 2023 06:29
Head branch was pushed to by a user without write access
FGadvancer
approved these changes
Nov 28, 2023
cubxxw
approved these changes
Nov 28, 2023
openimbot
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Fixes #1421
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: