Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ⓜ️feat: openim docker fix #1502

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Ⓜ️feat: openim docker fix #1502

merged 7 commits into from
Nov 30, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Nov 30, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Please ensure that the Docker script is compatible. Thank you for your attention to this matter.

🅰 Which issue(s) this PR fixes:

Fixes #1501

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Copy link
Contributor

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0efc235) 4.86% compared to head (cb770d1) 4.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1502   +/-   ##
=====================================
  Coverage   4.86%   4.86%           
=====================================
  Files         49      49           
  Lines       4256    4256           
=====================================
  Hits         207     207           
  Misses      4037    4037           
  Partials      12      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw changed the title Feat/openim docker fix Ⓜ️feat: openim docker fix Nov 30, 2023
@cubxxw cubxxw added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 4b19202 Nov 30, 2023
23 checks passed
@cubxxw cubxxw deleted the feat/openim-docker-fix branch November 30, 2023 10:25
@github-actions github-actions bot added this to the v3.1 milestone Nov 30, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Docker Compose Setup for Improved Isolation in OpenIM
4 participants