Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provides a new reading scheme for profile privacy through environment variables #1520

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 5, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

**about fix make init
/kind bug

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Could you please help me write a PR description? The task is to modify the code logic by changing the password reading strategy from the configuration file to reading from environment variables. The PR should have the following title: "feat: Provides a new reading scheme for profile privacy through environment variables". Thank you so much for your assistance!

🅰 Which issue(s) this PR fixes:

Fixes #1516
Resolves #1496,

Mysql -> Mongo
Fixes #1505

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Copy link
Contributor

sweep-ai bot commented Dec 5, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw enabled auto-merge December 5, 2023 08:41
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0194f6) 4.88% compared to head (037c165) 4.88%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1520   +/-   ##
=====================================
  Coverage   4.88%   4.88%           
=====================================
  Files         42      42           
  Lines       3787    3787           
=====================================
  Hits         185     185           
  Misses      3592    3592           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2023
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2023
@cubxxw cubxxw added this pull request to the merge queue Dec 5, 2023
Merged via the queue into openimsdk:main with commit 119e8db Dec 5, 2023
19 of 20 checks passed
@cubxxw cubxxw deleted the feat/openim-config-upgrade branch December 5, 2023 13:28
@github-actions github-actions bot added this to the v3.1 milestone Dec 5, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants