-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove docker compose mysql #1523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
cubxxw
requested review from
Bloomingg,
FGadvancer,
skiffer-git,
withchao and
a team
as code owners
December 5, 2023 13:56
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Dec 5, 2023
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
=====================================
Coverage 4.88% 4.88%
=====================================
Files 42 42
Lines 3787 3787
=====================================
Hits 185 185
Misses 3592 3592
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
openimbot
approved these changes
Dec 6, 2023
skiffer-git
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinwei Xiong(cubxxw) 3293172751nss@gmail.com
🔍 What type of PR is this?
/kind documentation
/kind feature
**about
fix make init
/kind bug
👀 What this PR does / why we need it:
Could you please help me write a PR description? The task is to modify the code logic by changing the password reading strategy from the configuration file to reading from environment variables. The PR should have the following title: "feat: Provides a new reading scheme for profile privacy through environment variables". Thank you so much for your assistance!
🅰 Which issue(s) this PR fixes:
Fixes #1516
Resolves #1496,
Mysql -> Mongo
Fixes #1505
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: