Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: online notifications do not push to herself. #1528

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

FGadvancer
Copy link
Collaborator

@FGadvancer FGadvancer commented Dec 6, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1527

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cd2713) 4.88% compared to head (75f0dbb) 4.88%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1528   +/-   ##
=====================================
  Coverage   4.88%   4.88%           
=====================================
  Files         42      42           
  Lines       3787    3787           
=====================================
  Hits         185     185           
  Misses      3592    3592           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Dec 6, 2023
Merged via the queue into openimsdk:main with commit 60f4f67 Dec 6, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Dec 6, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the online notification messages will be pushed to the sender.
3 participants