Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crud for general function user process, add pinFriend #1532

Merged
merged 71 commits into from
Dec 18, 2023

Conversation

AndrewZuo01
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • [x ] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

add crud for general function user process. For example, add to favorite

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c8463a0) 5.16% compared to head (9882da6) 5.15%.

Files Patch % Lines
pkg/common/convert/friend.go 0.00% 1 Missing ⚠️
pkg/common/http/http_client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1532      +/-   ##
========================================
- Coverage   5.16%   5.15%   -0.01%     
========================================
  Files         42      42              
  Lines       3759    3760       +1     
========================================
  Hits         194     194              
- Misses      3554    3555       +1     
  Partials      11      11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Show resolved Hide resolved
@cubxxw cubxxw added this pull request to the merge queue Dec 18, 2023
Merged via the queue into openimsdk:main with commit 8761056 Dec 18, 2023
25 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Dec 18, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants