Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenIM server, environment support for Docker Compose, and Kubernetes deployment. #1559

Merged
merged 20 commits into from
Dec 18, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 13, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

I have fixed the make init and init-config.sh scripts to support openim-docker. Additionally, I have added environment variables. Thank you for bringing this to my attention.

🅰 Which issue(s) this PR fixes:

Fixes #1504
Fixes #1513

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c5c5b2f) 4.81% compared to head (7e7ac9e) 5.16%.

Files Patch % Lines
pkg/common/db/cache/init_redis.go 0.00% 15 Missing ⚠️
pkg/common/discoveryregister/discoveryregister.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1559      +/-   ##
========================================
+ Coverage   4.81%   5.16%   +0.34%     
========================================
  Files         42      42              
  Lines       3843    3759      -84     
========================================
+ Hits         185     194       +9     
+ Misses      3648    3554      -94     
- Partials      10      11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@cubxxw cubxxw changed the title feat: add openim feat: Add OpenIM server, environment support for Docker Compose, and Kubernetes deployment. Dec 14, 2023
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw added this pull request to the merge queue Dec 18, 2023
Merged via the queue into openimsdk:main with commit f1c9686 Dec 18, 2023
20 of 21 checks passed
@cubxxw cubxxw deleted the feat/support-docker-en branch December 18, 2023 02:24
@github-actions github-actions bot added this to the v3.1 milestone Dec 18, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
5 participants