-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenIM server, environment support for Docker Compose, and Kubernetes deployment. #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubxxw
requested review from
Bloomingg,
FGadvancer,
skiffer-git,
withchao and
a team
as code owners
December 13, 2023 08:24
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Dec 13, 2023
Apply Sweep Rules to your PR?
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
========================================
+ Coverage 4.81% 5.16% +0.34%
========================================
Files 42 42
Lines 3843 3759 -84
========================================
+ Hits 185 194 +9
+ Misses 3648 3554 -94
- Partials 10 11 +1 ☔ View full report in Codecov by Sentry. |
pull-request-size
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Dec 14, 2023
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
cubxxw
changed the title
feat: add openim
feat: Add OpenIM server, environment support for Docker Compose, and Kubernetes deployment.
Dec 14, 2023
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
skiffer-git
approved these changes
Dec 18, 2023
luhaoling
approved these changes
Dec 18, 2023
openimbot
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
I have fixed the make init and init-config.sh scripts to support openim-docker. Additionally, I have added environment variables. Thank you for bringing this to my attention.
🅰 Which issue(s) this PR fixes:
Fixes #1504
Fixes #1513
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: