Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multipe msggateway services in k8s deployments #1565

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

xuexihuang
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1564

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2023
@kubbot
Copy link
Member

kubbot commented Dec 14, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


lin.huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Contributor

sweep-ai bot commented Dec 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (01c3d47) 4.88% compared to head (b976b7c) 4.81%.

Files Patch % Lines
pkg/common/discoveryregister/discoveryregister.go 0.00% 59 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1565      +/-   ##
========================================
- Coverage   4.88%   4.81%   -0.08%     
========================================
  Files         42      42              
  Lines       3787    3843      +56     
========================================
  Hits         185     185              
- Misses      3592    3648      +56     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuexihuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@cubxxw cubxxw added this pull request to the merge queue Dec 17, 2023
Merged via the queue into openimsdk:main with commit c5c5b2f Dec 17, 2023
20 of 21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Dec 17, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support multiple msggateway services for k8s deployment
4 participants