Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s environment supports multiple msggateway by consistent hash #1600

Merged
merged 10 commits into from
Dec 25, 2023

Conversation

xuexihuang
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1599

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2023
@kubbot
Copy link
Member

kubbot commented Dec 22, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (xuexihuang)[https://github.com/xuexihuang]
❌ @lin.huang
lin.huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@xuexihuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

sweep-ai bot commented Dec 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ed5f012) 5.15% compared to head (d71823e) 5.15%.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1600      +/-   ##
========================================
- Coverage   5.15%   5.15%   -0.01%     
========================================
  Files         42      42              
  Lines       3760    3761       +1     
========================================
  Hits         194     194              
- Misses      3555    3556       +1     
  Partials      11      11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cubxxw
cubxxw previously approved these changes Dec 22, 2023
@xuexihuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@xuexihuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@skiffer-git skiffer-git merged commit 34ed032 into openimsdk:main Dec 25, 2023
20 of 21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Dec 25, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: K8s environment supports multiple msggateway by consistent hash
5 participants