feat: add the notificationAccount #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhaoling
requested review from
skiffer-git,
FGadvancer,
a team,
cubxxw,
Bloomingg and
withchao
as code owners
pull-request-size
bot
added
the
size/L
Apply Sweep Rules to your PR?
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
========================================
- Coverage 5.15% 5.15% -0.01%
========================================
Files 42 42
Lines 3761 3762 +1
========================================
Hits 194 194
- Misses 3556 3557 +1
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
========================================
- Coverage 5.15% 5.15% -0.01%
========================================
Files 42 42
Lines 3761 3762 +1
========================================
Hits 194 194
- Misses 3556 3557 +1
Partials 11 11 ☔ View full report in Codecov by Sentry. |
|
Could you please take a look at the CICD error and resolve it? Thank you! |
FGadvancer
approved these changes
Dec 25, 2023
cubxxw
approved these changes
Dec 26, 2023
| @@ -53,6 +53,11 @@ type friendServer struct { | |||
| RegisterCenter registry.SvcDiscoveryRegistry | |||
| } | |||
|
|
|||
| func (s *friendServer) UpdateFriends(ctx context.Context, req *pbfriend.UpdateFriendsReq) (*pbfriend.UpdateFriendsResp, error) { | |||
| //TODO implement me | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Fixes #1582
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: