Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openimci.yml #1610

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Update openimci.yml #1610

merged 2 commits into from
Dec 26, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 26, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7389639) 5.15% compared to head (bffcb1b) 5.15%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1610   +/-   ##
=====================================
  Coverage   5.15%   5.15%           
=====================================
  Files         42      42           
  Lines       3762    3762           
=====================================
  Hits         194     194           
  Misses      3557    3557           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 26, 2023
@cubxxw cubxxw added this pull request to the merge queue Dec 26, 2023
Merged via the queue into main with commit 47dd6b1 Dec 26, 2023
25 checks passed
@cubxxw cubxxw deleted the cubxxw-patch-1 branch December 26, 2023 04:17
@github-actions github-actions bot added this to the v3.1 milestone Dec 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants