fix: Bash Compatibility in print_services_and_ports Function #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
This Pull Request addresses the compatibility issue in the print_services_and_ports function found in check-all.sh, enabling it to work with Bash versions older than 4.3. The solution involves removing the use of named references (local -n), which are not supported in older Bash versions.
🅰 Which issue(s) this PR fixes:
Rewritten print_services_and_ports to accept arrays directly as arguments.
The function now handles service names and ports without relying on named references, ensuring compatibility with a broader range of Bash environments.
The modified script has been tested in environments with both older (pre-4.3) and newer versions of Bash.
All tests ensure that the function correctly prints services and their corresponding ports without errors.
Fixes #1642
📝 Special notes for your reviewer:
🎯 Describe how to verify it
While this change aims at increasing compatibility, performance impacts (if any) on environments with large arrays should be minimal.
Further testing in varied environments is recommended to ensure consistent behavior.
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: