-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix openim server install scripts #1648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
=====================================
Coverage 5.12% 5.12%
=====================================
Files 42 42
Lines 3782 3782
=====================================
Hits 194 194
Misses 3577 3577
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Apply Sweep Rules to your PR?
|
skiffer-git
approved these changes
Jan 2, 2024
kubbot
approved these changes
Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinwei Xiong (cubxxw) 3293172751nss@gmail.com
🔍 What type of PR is this?
/kind bug
👀 What this PR does / why we need it:
This PR addresses an issue in the deployment script where the script would not fail upon encountering errors during the
docker compose up -d
process. The modification ensures that the script checks the status of Docker containers immediately after they are started. If any container fails to start, the script will now output an error message and logs before exiting. This enhancement is crucial for maintaining the robustness and reliability of the deployment process.🅰 Which issue(s) this PR fixes:
Fixes a critical issue where the deployment script would not correctly report failures during the Docker container startup process.
📝 Special notes for your reviewer:
Please note the added check after the
docker compose up -d
command, ensuring that any container startup failure is caught and handled appropriately.🎯 Describe how to verify it
To verify this update, execute the modified script in an environment where Docker containers are being deployed. Intentionally create a scenario where a container fails to start and observe if the script correctly identifies the failure and exits.
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:
N/A