Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix openim server install scripts #1648

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Jan 2, 2024

Signed-off-by: Xinwei Xiong (cubxxw) 3293172751nss@gmail.com


🔍 What type of PR is this?

/kind bug

👀 What this PR does / why we need it:

This PR addresses an issue in the deployment script where the script would not fail upon encountering errors during the docker compose up -d process. The modification ensures that the script checks the status of Docker containers immediately after they are started. If any container fails to start, the script will now output an error message and logs before exiting. This enhancement is crucial for maintaining the robustness and reliability of the deployment process.

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes a critical issue where the deployment script would not correctly report failures during the Docker container startup process.

📝 Special notes for your reviewer:

Please note the added check after the docker compose up -d command, ensuring that any container startup failure is caught and handled appropriately.

🎯 Describe how to verify it

To verify this update, execute the modified script in an environment where Docker containers are being deployed. Intentionally create a scenario where a container fails to start and observe if the script correctly identifies the failure and exits.

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

N/A

Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49f4e3f) 5.12% compared to head (6cf3b32) 5.12%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1648   +/-   ##
=====================================
  Coverage   5.12%   5.12%           
=====================================
  Files         42      42           
  Lines       3782    3782           
=====================================
  Hits         194     194           
  Misses      3577    3577           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

sweep-ai bot commented Jan 2, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit d594d6f Jan 2, 2024
33 checks passed
@cubxxw cubxxw deleted the feat/add-openim-server branch January 2, 2024 04:43
@github-actions github-actions bot added this to the v3.1 milestone Jan 2, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants