Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust the logic in multiTerminalLoginChecker to prevent onlineUserNum from decreasing below zero, thereby avoiding negative values. #1658

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

FGadvancer
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1657

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@FGadvancer FGadvancer requested review from skiffer-git, a team and cubxxw as code owners January 2, 2024 08:01
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2024
Copy link
Contributor

sweep-ai bot commented Jan 2, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d594d6f) 5.11% compared to head (677ee2c) 5.12%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1658   +/-   ##
=====================================
  Coverage   5.11%   5.12%           
=====================================
  Files         42      42           
  Lines       3792    3789    -3     
=====================================
  Hits         194     194           
+ Misses      3587    3584    -3     
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw enabled auto-merge January 2, 2024 08:36
@cubxxw cubxxw added this pull request to the merge queue Jan 3, 2024
Merged via the queue into openimsdk:main with commit 5d1cf8c Jan 3, 2024
22 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Jan 3, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: How can a negative number appear in "online user Num"?
4 participants