Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Notification update resp #1663

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1652

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2024
Copy link
Contributor

sweep-ai bot commented Jan 3, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1ba5c2) 5.11% compared to head (cb23b73) 5.11%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1663   +/-   ##
=====================================
  Coverage   5.11%   5.11%           
=====================================
  Files         42      42           
  Lines       3792    3792           
=====================================
  Hits         194     194           
  Misses      3587    3587           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luhaoling luhaoling requested review from cubxxw, withchao and a team as code owners January 3, 2024 04:30
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2024
@cubxxw cubxxw added this pull request to the merge queue Jan 3, 2024
Merged via the queue into openimsdk:main with commit 587533d Jan 3, 2024
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Jan 3, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: searchNotificationAccount return error
4 participants