Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): fix openim docker start openim server internal port lock #1673

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Jan 4, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Due to some special circumstances, the ports mapped during Docker deployment are currently dynamic for both internal and external ports. This is not ideal. We should consider fixing the mapping of internal ports by using export to make them static.

🅰 Which issue(s) this PR fixes:

resolves openimsdk/openim-docker#68
resolves openimsdk/openim-docker#59

📝 Special notes for your reviewer:

🎯 Describe how to verify it

Could you please review the CICD build and verify the local openim-docker repository? Thank you!

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

luhaoling and others added 4 commits January 3, 2024 15:39
fix: fix the imAdmin permission and searchNoficitaion resp
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Copy link
Contributor

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e2a256) 5.12% compared to head (c70ee5c) 5.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1673   +/-   ##
=====================================
  Coverage   5.12%   5.12%           
=====================================
  Files         42      42           
  Lines       3789    3789           
=====================================
  Hits         194     194           
  Misses      3584    3584           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw changed the title feat: fix openim docker start openim server internal port lock feat(main): fix openim docker start openim server internal port lock Jan 4, 2024
@cubxxw cubxxw enabled auto-merge January 4, 2024 07:58
@cubxxw cubxxw added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 09c3229 Jan 4, 2024
35 checks passed
@cubxxw cubxxw deleted the feat/add-docker-start branch January 4, 2024 08:01
@github-actions github-actions bot added this to the v3.1 milestone Jan 4, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot change openim ws port Bug: cannot change API_OPENIM_PORT
4 participants