Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dissmissGroup and lack of keyword bug #1678

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1672

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2024
Copy link
Contributor

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (16bc053) 5.12% compared to head (d8fa711) 5.12%.
Report is 13 commits behind head on release-v3.5.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 65 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-v3.5   #1678      +/-   ##
===============================================
- Coverage          5.12%   5.12%   -0.01%     
===============================================
  Files                42      42              
  Lines              3782    3789       +7     
===============================================
  Hits                194     194              
- Misses             3577    3584       +7     
  Partials             11      11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGadvancer FGadvancer merged commit d446bdb into openimsdk:release-v3.5 Jan 4, 2024
12 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants