fix: add message typing field and fix the CallbackSingleMsgRead callback unuse error #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhaoling
requested review from
skiffer-git,
FGadvancer,
a team and
cubxxw
as code owners
pull-request-size
bot
added
the
size/S
luhaoling
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v3.5 #1784 +/- ##
============================================
Coverage 5.10% 5.10%
============================================
Files 42 42
Lines 3797 3797
============================================
Hits 194 194
Misses 3592 3592
Partials 11 11 ☔ View full report in Codecov by Sentry. |
cubxxw
approved these changes
Jan 19, 2024
|
Title not in proper format, please change the title to: fix(release-v3.5): add message typing field and fix the CallbackSingleMsgRead callback unused error #1784 |
FGadvancer
approved these changes
Jan 19, 2024
|
|
|
|
\gtm |
\gtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Fixes #1727 #1785
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: