Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: replace the component check func by tools pkg #1846

Merged
merged 15 commits into from
Feb 1, 2024

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1805

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f94d8af) 5.33% compared to head (78a5e0b) 5.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1846   +/-   ##
=====================================
  Coverage   5.33%   5.33%           
=====================================
  Files         43      43           
  Lines       3823    3823           
=====================================
  Hits         204     204           
  Misses      3606    3606           
  Partials      13      13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Feb 1, 2024
Merged via the queue into openimsdk:main with commit 55ca661 Feb 1, 2024
25 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Feb 1, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: replace the component check func by tools pkg
3 participants