Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process add errors wrap. #1862

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: process add errors wrap. #1862

merged 2 commits into from
Feb 2, 2024

Conversation

FGadvancer
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1861

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (55ca661) 5.33% compared to head (b31042b) 5.33%.

❗ Current head b31042b differs from pull request most recent head 2f11188. Consider uploading reports for the commit 2f11188 to get more accurate results

Files Patch % Lines
internal/tools/cron_task.go 0.00% 5 Missing ⚠️
internal/tools/msg.go 0.00% 4 Missing ⚠️
pkg/common/db/cache/init_redis.go 0.00% 2 Missing ⚠️
pkg/common/startrpc/start.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1862      +/-   ##
========================================
- Coverage   5.33%   5.33%   -0.01%     
========================================
  Files         43      43              
  Lines       3823    3827       +4     
========================================
  Hits         204     204              
- Misses      3606    3610       +4     
  Partials      13      13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skiffer-git
skiffer-git previously approved these changes Feb 2, 2024
@cubxxw cubxxw enabled auto-merge February 2, 2024 02:10
@cubxxw cubxxw added this pull request to the merge queue Feb 2, 2024
Merged via the queue into openimsdk:main with commit c55e03d Feb 2, 2024
18 of 21 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Feb 2, 2024
@github-actions github-actions bot added this to the v3.1 milestone Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization: process needs more detailed information when the server cannot start normally.
4 participants