-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process add errors wrap. #1862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGadvancer
requested review from
cubxxw,
skiffer-git and
a team
as code owners
February 1, 2024 13:07
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
========================================
- Coverage 5.33% 5.33% -0.01%
========================================
Files 43 43
Lines 3823 3827 +4
========================================
Hits 204 204
- Misses 3606 3610 +4
Partials 13 13 ☔ View full report in Codecov by Sentry. |
skiffer-git
previously approved these changes
Feb 2, 2024
cubxxw
approved these changes
Feb 2, 2024
kubbot
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Fixes #1861
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: