Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization: message remove options. #2082

Merged
merged 5 commits into from Mar 13, 2024
Merged

Conversation

FGadvancer
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #2081

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.62%. Comparing base (0b2df42) to head (459a5a1).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2082      +/-   ##
========================================
- Coverage   4.63%   4.62%   -0.01%     
========================================
  Files         28      28              
  Lines       1814    1816       +2     
========================================
  Hits          84      84              
- Misses      1720    1722       +2     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw enabled auto-merge March 13, 2024 04:28
@cubxxw cubxxw added this pull request to the merge queue Mar 13, 2024
Merged via the queue into openimsdk:main with commit e86d1cd Mar 13, 2024
26 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Mar 13, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: only messages sent online will appear in the conversation.
3 participants