Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the callback after reading the group message #2114

Merged
merged 1 commit into from Mar 19, 2024

Conversation

honlyc
Copy link
Contributor

@honlyc honlyc commented Mar 18, 2024


🔍 What type of PR is this?

/kind bug

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #2109

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@honlyc honlyc requested review from skiffer-git, FGadvancer and a team as code owners March 18, 2024 02:33
@honlyc honlyc requested a review from Bloomingg March 18, 2024 02:33
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
@kubbot
Copy link
Member

kubbot commented Mar 18, 2024

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@honlyc
Copy link
Contributor Author

honlyc commented Mar 18, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.62%. Comparing base (0b2df42) to head (2439af9).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2114      +/-   ##
========================================
- Coverage   4.63%   4.62%   -0.01%     
========================================
  Files         28      28              
  Lines       1814    1816       +2     
========================================
  Hits          84      84              
- Misses      1720    1722       +2     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw
Copy link
Contributor

cubxxw commented Mar 18, 2024

recheck

openimbot added a commit to openim-sigs/cla that referenced this pull request Mar 18, 2024
@cubxxw cubxxw added this pull request to the merge queue Mar 19, 2024
Merged via the queue into openimsdk:main with commit 6d1062b Mar 19, 2024
26 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Mar 19, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot call back after reading the group message
4 participants