New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Path Resolution Error for Root Directory .env File Generation Update env-template.yaml #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubxxw
requested review from
Bloomingg,
FGadvancer,
skiffer-git,
withchao and
a team
as code owners
March 19, 2024 13:57
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Mar 19, 2024
OpenIM TestOpenIM API TestCommand Output for OpenIM API Test
OpenIM E2E TestCommand Output for OpenIM E2E Test
|
kubbot
approved these changes
Mar 20, 2024
openimbot
approved these changes
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
👀 What this PR does / why we need it:
This PR addresses a specific path resolution error encountered during the initialization process of the OpenIM server project, particularly affecting the generation of the
.env
file from its template. The issue leads to an incorrect path computation, resulting in a failure to generate or overwrite the.env
file located in the project's root directory, while other configuration files in subdirectories are handled without issue. This fix ensures uniform handling of both root and subdirectory path resolutions, enabling a seamless initialization and setup process for all project configuration files, including those at the root level.🅰 Which issue(s) this PR fixes:
Fixes #2127
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: