Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group dismissed trigger to UI. #332

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

FGadvancer
Copy link
Collaborator


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #331

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
@FGadvancer FGadvancer requested a review from a team as a code owner September 15, 2023 12:38
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2023
@FGadvancer FGadvancer temporarily deployed to openim September 15, 2023 12:38 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim September 15, 2023 12:38 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim September 15, 2023 12:38 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim September 15, 2023 12:38 — with GitHub Actions Inactive
@FGadvancer FGadvancer merged commit 07f8db9 into openimsdk:main Sep 15, 2023
6 checks passed
@FGadvancer FGadvancer changed the title Fork main fixgroup dismissed trigger to UI. Sep 18, 2023
@FGadvancer FGadvancer changed the title fixgroup dismissed trigger to UI. fix: group dismissed trigger to UI. Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the client did not receive a notification when the group was dismissed.
1 participant