Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add avatar and nickname when sessionType is notification. #379

Merged
merged 10 commits into from
Oct 19, 2023

Conversation

FGadvancer
Copy link
Collaborator


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #378

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
@sweep-ai
Copy link

sweep-ai bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
@FGadvancer FGadvancer temporarily deployed to openim October 19, 2023 13:13 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 19, 2023 13:13 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 19, 2023 13:13 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 19, 2023 13:13 — with GitHub Actions Inactive
@FGadvancer FGadvancer merged commit 53aa556 into openimsdk:main Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: conversation avatar is empty when send OA notification message by api.
1 participant