Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: file read cache #396

Merged
merged 17 commits into from
Nov 2, 2023
Merged

feat: file read cache #396

merged 17 commits into from
Nov 2, 2023

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Nov 1, 2023


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #395

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested a review from a team as a code owner November 1, 2023 03:35
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2023
@withchao withchao temporarily deployed to openim November 1, 2023 03:35 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 03:35 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 03:35 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 03:35 — with GitHub Actions Inactive
Copy link

sweep-ai bot commented Nov 1, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@FGadvancer FGadvancer merged commit 24a1a58 into openimsdk:main Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: file upload and reading are slow
2 participants