Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: large file signing timeout #403

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix: large file signing timeout #403

merged 4 commits into from
Nov 8, 2023

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Nov 7, 2023


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #402

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested a review from a team as a code owner November 7, 2023 10:13
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@cubxxw cubxxw enabled auto-merge November 8, 2023 09:23
@cubxxw cubxxw added this pull request to the merge queue Nov 8, 2023
Merged via the queue into openimsdk:main with commit 3e92f43 Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiffer-git skiffer-git skiffer-git approved these changes

@cubxxw cubxxw cubxxw approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Other]: large file signing timeout
3 participants
@withchao @skiffer-git @cubxxw