Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull message unread count remove. #404

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

FGadvancer
Copy link
Collaborator


馃攳 What type of PR is this?

馃憖 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

馃叞 Which issue(s) this PR fixes:

Fixes #

馃摑 Special notes for your reviewer:

馃幆 Describe how to verify it

馃搼 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
@FGadvancer FGadvancer requested a review from a team as a code owner November 9, 2023 04:15
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 9, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Copy link

sweep-ai bot commented Nov 9, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2023
@FGadvancer FGadvancer merged commit ce8c120 into openimsdk:main Nov 9, 2023
5 checks passed
@FGadvancer FGadvancer deleted the refactor/change_login_export branch November 9, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant